allow Path object to be passed as default #411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem that this PR addresses?
More often than not, when we prompt the user for a path, we later construct a builtin
Path
object from the received string. Following this notion, it is only logical that such object can also be passed asdefault
parameter to thequestionary.path()
function.How did you solve it?
We expand the type of
default
parameter toPath | str
while also keeping its default value to be an empty string. Then we change the reference to this parameter on line 242 and we cast it to string usingstr(default)
. Ifdefault
is of typePath
, then we recieve the corresponding path as a string, if its type isstr
then nothing happens.Checklist