Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support builds using Visual Studio #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support builds using Visual Studio #15

wants to merge 3 commits into from

Conversation

fanc999
Copy link

@fanc999 fanc999 commented Feb 11, 2020

Hi,

This adds NMake build files to enable libdatrie to be buildable with Visual Studio 2008 and later in both 32-bit and 64-bit (x86-64) flavours,

where:

  • libdatrie is built as a DLL with pkg-config file generated
  • One can opt to build trietool.exe and the tests

Please note that one of the test programs is updated slightly not to include unistd.h on Windows. All the rest of the existing code are left untouched.

With blessings, thank you!

@fanc999 fanc999 force-pushed the master branch 3 times, most recently from 889f887 to 9d83bc6 Compare February 14, 2020 05:15
thep
thep reviewed Jan 19, 2021
View reviewed changes
Copy link
Contributor

@thep thep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about replacing unlink() calls in main() with remove() from <stdio.h> and getting rid of <unistd.h> completely?

thep added a commit that referenced this pull request Jan 22, 2021
@thep
Get rid of <unistd.h> include.
3a37e64 
* tests/test_file.c (main):
  - Replace unlink() calls with remove() from <stdio.h> and drop
    <unistd.h> include, fixing build issue on Windows.

Addressing Windows build issue differently from what proposed by
@fanc999 in pull request #15. Thanks @fanc999 for first raising this.
@whs whs mentioned this pull request Sep 5, 2021
Open
@fanc999-1
Add Visual Studio NMake Makefiles
7aed4d9 
* configure.ac:
* Makefile.am:
* win32/*:
  - Support building libdatrie as a DLL with Visual Studio.
    building trietool.exe and the tests are also supported.
@fanc999-1
NMake Makefiles: Support ARM64 builds
86feff2 
Add detection logic for ARM64 builds, since we can support Windows 10+ on ARM64
with the appropriate Compiler/Linker flags.
@fanc999-1
NMake Makefiles: Support Visual Studio 2022
f77af65 
Make sure that things are set apart from the 2019 builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thep thep thep left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fanc999 @thep @fanc999-1