Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

native: legacy detail views as content renderers #4219

Closed
wants to merge 5 commits into from
Closed

native: legacy detail views as content renderers #4219

wants to merge 5 commits into from

Commits on Nov 22, 2024

  1. Define MinimalRenderItemProps as a subset of RenderItemProps

    @davidisaaclee
    davidisaaclee committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    b5ac4ca View commit details
    Browse the repository at this point in the history

  2. Enable passing other ActionSheet props to SimpleActionSheet

    @davidisaaclee
    davidisaaclee committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    e9b3074 View commit details
    Browse the repository at this point in the history

  3. Optionally disallow scrollable content in SimpleActionSheet 

    I defaulted this to enable scrollable content. I think there are not
many cases where you'd want to disable scroll: scroll is an easy fix
for accessibility on small screens.

To avoid issue, I set all existing uses of `SimpleActionSheet` to
`disableScroll`.
    @davidisaaclee
    davidisaaclee committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    366aef6 View commit details
    Browse the repository at this point in the history

  4. Make configuration picker avoid growing past top of screen

    @davidisaaclee
    davidisaaclee committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    8c11c23 View commit details
    Browse the repository at this point in the history

  5. Add gallery and notebook legacy detail views as content renderers

    @davidisaaclee
    davidisaaclee committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    acb3174 View commit details
    Browse the repository at this point in the history