profile & expose: fix integration with contacts #4217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikolajpp
force-pushed
the
mp/contacts-activity-backend
branch
from
eb40e79
to
f5dfc8f
Compare
|
Fixes TLON-3253 |
Fang-
reviewed
Nov 22, 2024
Fang-
approved these changes
Nov 22, 2024
| ?- -.sign | ||
| %poke-ack !! | ||
| %kick [[%pass /contacts %agent [our.bowl %conacts] %watch /contact]~ this] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some outdated type references in %expose that were preventing the upgrade. Additionally, both %profile and %expose were using the removed
/contactAPI endpoint. For now we just migrate to subscribing to/newsand filtering on our own profile updates. We should migrate these two agents to use new %contacts API soon.