-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom channels: fixup new thread view #4213
Open
davidisaaclee
wants to merge
16
commits into
dil/demo/custom-everything
Choose a base branch
from
dil/custom-channels/fix-custom-detail-view-comments
base: dil/demo/custom-everything
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
custom channels: fixup new thread view #4213
davidisaaclee
wants to merge
16
commits into
dil/demo/custom-everything
from
dil/custom-channels/fix-custom-detail-view-comments
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidisaaclee
force-pushed
the
dil/custom-channels/fix-custom-detail-view-comments
branch
from
November 21, 2024 05:21
8d1eca6
to
093aabd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands on the new post detail / thread screen added in #4188:
chat
input)This branch includes #4212 as the beginning range of commits – to view without that branch, see https://github.com/tloncorp/tlon-apps/pull/4213/files/8822aa9c5bf0f111f6981af21b059c73d81086de..093aabdfab84ec893c551927fd233c620a67282f
Simulator.Screen.Recording.-.iPhone.15.-.2024-11-20.at.21.26.18.mp4