native: integrate new contacts into UI #4127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te contact metadata
…eader button for getting to contacts page
latter-bolden
force-pushed
the
lb/contacts-ui
branch
from
41b2250
to
e93d884
Compare
latter-bolden
requested review from
dnbrwstr,
jamesacklin and
patosullivan
and removed request for
dnbrwstr,
arthyn and
mikolajpp
dnbrwstr
approved these changes
Nov 21, 2024
| @@ -23,5 +23,5 @@ export function formatUserId( | |||
| } | |||
|
|
|||
| export function getDisplayName(contact: db.Contact) { | |||
There was a problem hiding this comment.
Can contact be empty? Either the param should be optional/nullable, or we shouldn't need this check here.
| @@ -186,6 +206,37 @@ export const activityEvents = sqliteTable( | |||
| } | |||
| ); | |||
|
|
|||
| export const activityEventContactGroups = sqliteTable( | |||
| 'activyt_event_contact_group_pins', | |||
|
|
||
| peerNickname: text('peerNickname'), | ||
| customNickname: text('customNickname'), | ||
| nickname: text('nickname').generatedAlwaysAs( |
| @@ -72,53 +161,192 @@ export const removePinnedGroup = async (groupId: string) => { | |||
| }); | |||
| }; | |||
|
|
|||
| export const setPinnedGroups = async (groupIds: string[]) => { | |||
| console.log(`api set pinned`, groupIds); | |||
There was a problem hiding this comment.
stray logs in this function
| return Object.entries(contacts).flatMap(([ship, contact]) => | ||
| contact === null ? [] : [toClientContact(ship, contact)] | ||
| ); | ||
| export const v0PeersToClientProfiles = ( |
There was a problem hiding this comment.
A comment about what a v0Peer is would be nice
| @@ -19,11 +19,20 @@ function SummaryMessageRaw({ | |||
| const plural = summary.all.length > 1; | |||
| const authors = useActivitySummaryAuthors(summary); | |||
|
|
|||
| console.log(`summary message debug`, { | |||
| const [pinnedGroups, setPinnedGroups] = useState<db.Group[]>( | ||
| (userContact?.pinnedGroups | ||
| ?.map((pin) => pin.group) | ||
| .filter(Boolean) as db.Group[]) ?? [] | ||
| ); | ||
|
|
||
| const currentNickname = useMemo(() => { | ||
| return props.userId === currentUserId |
There was a problem hiding this comment.
Lotsa reps of props.userId === currentUserId, would be nice to just have an isCurrentUser local var
| imageUrl={overrideUrl ?? contact?.avatarImage ?? undefined} | ||
| imageUrl={ | ||
| overrideUrl ?? | ||
| contact?.customAvatarImage ?? |
There was a problem hiding this comment.
Doesn't the calculated column for contact.avatarImage already handle coalescing these values?
| } | ||
|
|
||
| return ( | ||
| <View paddingLeft="$xl" paddingVertical="$xl"> |
There was a problem hiding this comment.
Use SectionListHeader, ensure contentContainerStyle matches ChatList
| @@ -2705,6 +2707,67 @@ export const updateContact = createWriteQuery( | |||
| ['contacts'] | |||
| ); | |||
|
|
|||
| export const upsertContact = createWriteQuery( | |||
| 'upsertContact', | |||
| async (contact: Contact, ctx: QueryCtx) => { | |||
There was a problem hiding this comment.
Does the insert/onConflict pattern we're using most other places not work here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for using the new contacts agent including:
You'll need to have contact activity enabled
%landscapeand%groupsto work with it (should now be on wannec)I still want to execute a rename on contacts table as discussed, but I don't think it needs to block.
Fixes TLON-3136
Fixes TLON-3192
Fixes TLON-2743
Fixes TLON-3218