Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activity: bug fixes #3559

Merged
merged 17 commits into from
Jun 4, 2024
Merged

activity: bug fixes #3559

merged 17 commits into from
Jun 4, 2024

Conversation

arthyn
Copy link
Member

@arthyn arthyn commented May 31, 2024 •
edited
Loading

frontend

  • Refactor unreads to all flow through same store
  • Simplify unread state to string options instead of juggling booleans
  • Adjust ID usage to reflect changes from backend
  • Change reply line color back to white in non-notify cases
  • Fix bug where sometimes navigating away doesn't clear current unread
  • Fix issue with group sidebar item not showing dot when children are unread
  • Fix issue with Messages sidebar not showing correct items
  • Groups are hanging on to unreads for some reason

backend

  • Proper JSON conversions for stream query
  • Adjust children handling so we don't double count
  • Fix bug where floor isn't updating in some cases
  • Simplify iteration logic when summarizing unreads
    Change message key ID time for channels so it reflects the time that - [X] mobile app is interested in and changed thread source to use same ID
  • Groups are hanging on to unreads for some reason

Fixes TLON-1974
Fixes TLON-1975

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

Base automatically changed from hm/further-activity to activity-release May 31, 2024 20:29
@arthyn
unreads: use correct store and keys
8d7e176
@arthyn
activity: make stream give streams
3532092
@arthyn
activity: refactor channel ids and fix floor bug
97a4062 
This fixes a bug where the floor was never fully updated. Also refactors
channel threads to use normal post ids instead of the synthesized ones
that match the form factor of DMs.
@linear Linear
Copy link

linear bot commented Jun 3, 2024

TLON-1974 activity: various fixes

@linear Linear
Copy link

linear bot commented Jun 4, 2024

TLON-1975 activity: various fixes (front-end)

@arthyn arthyn marked this pull request as ready for review June 4, 2024 17:14
Fang-
Fang- reviewed Jun 4, 2024
View reviewed changes
Copy link
Member

@Fang- Fang- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks, looks good otherwise.

desk/app/activity.hoon Outdated Show resolved Hide resolved
desk/app/activity.hoon Outdated Show resolved Hide resolved
@arthyn arthyn requested a review from Fang- June 4, 2024 17:57
Fang-
Fang- approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@Fang- Fang- left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend changes look good, thanks!

latter-bolden
latter-bolden approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@latter-bolden latter-bolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of functional review, this is feeling great!

Noticed a few quirks with sidebar dots (communicated out of band), but nothing blocking.

patosullivan
patosullivan approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@patosullivan patosullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, and brian's task in linear covers the other issues I've found (and I'm adding some comments with others).

apps/tlon-web/src/dms/MessagesSidebarItem.tsx Outdated Show resolved Hide resolved
@arthyn arthyn merged commit 8512281 into activity-release Jun 4, 2024
1 check failed
@arthyn arthyn deleted the hm/activity-bug-fixes branch June 4, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@latter-bolden latter-bolden latter-bolden approved these changes

@Fang- Fang- Fang- approved these changes

@patosullivan patosullivan patosullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arthyn @patosullivan @Fang- @latter-bolden