Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] initial idea for how to structure ephemeral deployment moons #3315

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

dosullivan
Copy link
Collaborator

Just trying to structure out how we could potentially start up ephemeral moons for development branches.

To make this work we need a hoon thread to run through click to generate a moon. We then need to write that output to a file, then extract the moon name and key, and then use that to boot the one-off moon. One problem I see with the current approach is that the bash script copied/ran on the VM host is very much a "one shot" type thing where the script is just ran one time, similar to how our current deploy.sh script is ran. Need to determine how we can actually see if the moon is successfully booted before moving forward with the deployment script itself.

@dosullivan dosullivan requested a review from arthyn March 6, 2024 23:02
General setup cribbed from the |moon generator. This achieves the same,
but in a thread, and produces a [@p (unit @uw)] result instead of just
printing it into the slogs.
Copy link
Member

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this generally makes sense. @Fang- reading this https://github.com/urbit/tools/wiki/conn.c-Usage-Guide it seems like the thread needs to be inlined and stripped of some of the opening imports and stuff since that's included in khan-eval right?

@arthyn arthyn merged commit 65819d5 into develop Mar 18, 2024
4 of 5 checks passed
@arthyn arthyn deleted the do/ephemeral-moons branch March 18, 2024 23:01
@arthyn
Copy link
Member

arthyn commented Mar 18, 2024

going to just push this through and we can make another PR with actual deploys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants