add support for heterogeneous files #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #156 +/- ##
==========================================
+ Coverage 93.48% 93.49% +0.01%
==========================================
Files 13 13
Lines 1151 1169 +18
==========================================
+ Hits 1076 1093 +17
- Misses 75 76 +1 ☔ View full report in Codecov by Sentry. |
tlnagy
approved these changes
Apr 1, 2024
| all(map(==(ncols(first(ifds))), ncols.(ifds))) && | ||
| all(map(==(colortype(first(ifds))), colortype.(ifds))) | ||
| end | ||
|
|
There was a problem hiding this comment.
Is this sufficient to determine homogeneity? I guess we can try with this and add more checks if they end up causing issues.
|
Awesome! Is there anything else you want to add to the release? I see that you bumped the version to 1.0, but I would like to fix #135 prior tagging v1.0 so I might make a new PR changing the release to v0.10.0 |
|
I have a PR for #100, but that may take some time to hash out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139