add support for LZW compression #116
Conversation
|
Wow, thanks! LZW support has been requested for awhile. I'll review this carefully later this week, but do you mind adding tests? I believe Also is this your own original implementation or was this adapted from somewhere? We just need to make sure the licenses are compatible if the latter. |
|
This implementation is not adapted or ported from any other code |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #116 +/- ##
==========================================
+ Coverage 90.20% 91.57% +1.36%
==========================================
Files 13 13
Lines 766 902 +136
==========================================
+ Hits 691 826 +135
- Misses 75 76 +1
☔ View full report in Codecov by Sentry. |
=== I've found inconsistent behavior between Houdini and Pixelmator, so defaulting to behavior consistent with the spec Images will load (apparently) correctly in either case, but we show a warning for missing EOI in the non-spec case
|
Do you mind bumping the version to |
|
Okay, I think this is good to go. I'll tag v0.6.8 first to release #121 and then we'll tag and release this PR as v0.7.0 |
|
Thanks @chrstphrbrns for pushing this all the way through! I think people will be very excited for this. |
Fixes #8
Validated using images from a variety of packages, using a variety of pixel formats, and comparing with uncompressed versions of the same image