feat: add --clear-cache option
#249
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add clear_cache function to clear the local cache - add the parser link to the fonction
kbdharun
changed the title
--clear-cache option
kbdharun
reviewed
Jun 28, 2024
- Added iteration over multiple languages, handling non-English languages dynamically. - Implemented recursive directory traversal to delete files and subdirectories within cache directories. - Improved error handling with detailed messages for file and directory deletion failures. thanks to @kbdharun Co-authored-by: K.B.Dharun Krishna <[email protected]>
vitorhcl
reviewed
Jul 17, 2024
Comment on lines
+501
to
+519
| # Recursively walk through the directory to delete files and subdirectories | ||
| for root, dirs, files in os.walk(cache_dir, topdown=False): | ||
| for name in files: | ||
| file_path = Path(root) / name | ||
| try: | ||
| file_path.unlink() # Attempt to delete the file | ||
| except Exception as e: | ||
| print(f"Error: Unable to delete cache file {file_path}: {e}") | ||
| for name in dirs: | ||
| dir_path = Path(root) / name | ||
| try: | ||
| dir_path.rmdir() # Attempt to delete the directory | ||
| except Exception as e: | ||
| print( | ||
| f"Error: Unable to delete cache directory {dir_path}: {e}" | ||
| ) | ||
| # Attempt to remove the main cache directory after clearing its contents | ||
| try: | ||
| cache_dir.rmdir() |
There was a problem hiding this comment.
Suggested change
| # Recursively walk through the directory to delete files and subdirectories | |
| for root, dirs, files in os.walk(cache_dir, topdown=False): | |
| for name in files: | |
| file_path = Path(root) / name | |
| try: | |
| file_path.unlink() # Attempt to delete the file | |
| except Exception as e: | |
| print(f"Error: Unable to delete cache file {file_path}: {e}") | |
| for name in dirs: | |
| dir_path = Path(root) / name | |
| try: | |
| dir_path.rmdir() # Attempt to delete the directory | |
| except Exception as e: | |
| print( | |
| f"Error: Unable to delete cache directory {dir_path}: {e}" | |
| ) | |
| # Attempt to remove the main cache directory after clearing its contents | |
| try: | |
| cache_dir.rmdir() | |
| try: | |
| shutil.rmtree(cache_dir) |
|
Hi @patricedenis, any updates on this? |
|
Hi. I haven't been involved recently, I'm sorry. I will try to look for the sugested shutil addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about adding an option to clear the local caches.
It is supposed to delete the files that store the tldr pages locally on your computer.
I was inspired by the same option that already exists on the tldr-node-client.
It may resolve #242 has after application, no local cache should remain on the storage.
Also I'm not sure that the workflow automates the build of the man page (this is not modified in current PR).
If not, I could try to modify the building workflow to allow that.
I would again be very pleased if someone could test this PR locally before merging if wanted because I haven't set a development environment yet.