Remove a condition to hide space from dropdown menu even if there's o… (

elastic#199601) ## Summary - Based [on the issue](https://github.com/orgs/elastic/projects/1102/views/15?pane=issue&itemId=86718686&issue=elastic%7Ckibana%7C199594), I removed a condition to hide space from dropdown menu even if there's only one (for admins and regular users) - I also changed the wording from "Your spaces" to just "Spaces" so that we're consistent in all cases, [based on this comment](elastic/UX#113 (comment)). --------- Co-authored-by: Elastic Machine <[email protected]>
tkajtoch · Nov 12, 2024 · 347dfac · 347dfac
1 parent c1bdaab
commit 347dfac
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/x-pack/plugins/spaces/public/nav_control/components/spaces_menu.tsx b/x-pack/plugins/spaces/public/nav_control/components/spaces_menu.tsx
@@ -117,7 +117,7 @@ class SpacesMenuUI extends Component<Props> {
               <EuiPopoverTitle paddingSize="s">
                 {search ||
                   i18n.translate('xpack.spaces.navControl.spacesMenu.selectSpacesTitle', {
-                    defaultMessage: 'Your spaces',
+                    defaultMessage: 'Spaces',
                   })}
               </EuiPopoverTitle>
               {list}

diff --git a/x-pack/plugins/spaces/public/nav_control/nav_control_popover.tsx b/x-pack/plugins/spaces/public/nav_control/nav_control_popover.tsx
@@ -97,7 +97,7 @@ class NavControlPopoverUI extends Component<Props, State> {
     const isTourOpen = Boolean(activeSpace) && this.state.showTour && !this.state.showSpaceSelector;
 
     let element: React.ReactNode;
-    if (this.state.loading || this.state.spaces.length < 2) {
+    if (this.state.loading) {
       element = (
         <SpacesDescription
           id={popoutContentId}

diff --git a/x-pack/plugins/translations/translations/fr-FR.json b/x-pack/plugins/translations/translations/fr-FR.json
@@ -45064,7 +45064,7 @@
     "xpack.spaces.navControl.spacesMenu.changeCurrentSpaceTitle": "Modifier l'espace en cours",
     "xpack.spaces.navControl.spacesMenu.findSpacePlaceholder": "Rechercher un espace",
     "xpack.spaces.navControl.spacesMenu.noSpacesFoundTitle": "aucun espace trouvé",
-    "xpack.spaces.navControl.spacesMenu.selectSpacesTitle": "Vos espaces",
+    "xpack.spaces.navControl.spacesMenu.selectSpacesTitle": "Espaces",
     "xpack.spaces.navControl.spacesMenu.spacesAriaLabel": "Espaces",
     "xpack.spaces.navControl.tour.closeBtn": "Fermer",
     "xpack.spaces.navControl.tour.content": "Il offre toutes les analyses et les fonctionnalités {solution} dont vous avez besoin. Vous pouvez changer de vue ou revenir à la navigation classique à partir des paramètres de votre espace, ou créer d'autres espaces avec des vues différentes. {learnMore}",

diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json
@@ -44332,7 +44332,7 @@
     "xpack.spaces.navControl.spacesMenu.changeCurrentSpaceTitle": "更改当前空间",
     "xpack.spaces.navControl.spacesMenu.findSpacePlaceholder": "查找工作区",
     "xpack.spaces.navControl.spacesMenu.noSpacesFoundTitle": "未找到工作区",
-    "xpack.spaces.navControl.spacesMenu.selectSpacesTitle": "您的工作区",
+    "xpack.spaces.navControl.spacesMenu.selectSpacesTitle": "工作区",
     "xpack.spaces.navControl.spacesMenu.spacesAriaLabel": "工作区",
     "xpack.spaces.navControl.tour.closeBtn": "关闭",
     "xpack.spaces.navControl.tour.content": "它提供了您需要的所有分析和 {solution} 功能。您可以切换视图，或从工作区设置中返回到经典导航，或创建其他具有不同视图的工作区。{learnMore}",