Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Updated api documentation #200

Merged
merged 5 commits into from
Feb 6, 2022
Merged

Conversation

tjarbo
Copy link
Owner

@tjarbo tjarbo commented Feb 5, 2022

Description

As part of #130, many api endpoints were replaced by new ones. This updated includes the updated version of the api documentation available on /api/docs. I double checked it to ensure every endpoint is correctly displayed but maybe you have the time to check this again - it always easy to overlook something 😅 Thank you!

The documentation is buold with stoplight.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • Make sure you are requesting to main. Don't request to release branch!
  • I have linked the related issue.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tjarbo tjarbo added 👓 need review This issue or pull request needs to be reviewed ⚡ improvement Verbesserung bestehender Funktionen labels Feb 5, 2022
@tjarbo tjarbo self-assigned this Feb 5, 2022
@tjarbo
Copy link
Owner Author

tjarbo commented Feb 5, 2022

@p-fruck you mentationed, that you know a package that uses jsdocs comments or something like that to generate an api docu from comments - which was it ?

@p-fruck
Copy link
Collaborator

p-fruck commented Feb 6, 2022

@tjarbo once upon a time I used to use swagger-jsdoc in combination with swagger-express-ui. StudyOffline is an example project using this setup. You can see the swagger-ui being served using express as well as our swagger documentation being written inline as comments for the express router functions. Note that the swagger documentation is generated at runtime, not at compile time, in the example project.

packages/backend/src/docs/rest-api.json Outdated Show resolved Hide resolved
packages/backend/src/docs/rest-api.json Outdated Show resolved Hide resolved
packages/backend/src/docs/rest-api.json Outdated Show resolved Hide resolved
packages/backend/src/docs/rest-api.json Outdated Show resolved Hide resolved
packages/backend/src/docs/rest-api.json Outdated Show resolved Hide resolved
packages/backend/src/docs/rest-api.json Outdated Show resolved Hide resolved
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to complain about newline, but for some reasons vscode removes them automatically from json documents. Actually, the reason is quite valid, but nevertheless I'd like to request this newline.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added with 180b964

@tjarbo tjarbo requested a review from p-fruck February 6, 2022 09:45
packages/backend/src/docs/rest-api.json Outdated Show resolved Hide resolved
packages/backend/src/docs/rest-api.json Outdated Show resolved Hide resolved
packages/backend/src/docs/rest-api.json Outdated Show resolved Hide resolved
packages/backend/src/docs/rest-api.json Outdated Show resolved Hide resolved
@tjarbo tjarbo requested a review from p-fruck February 6, 2022 12:50
@tjarbo tjarbo merged commit 6bb13e4 into version-2 Feb 6, 2022
@tjarbo tjarbo deleted the tjarbo/update-documentation branch February 6, 2022 13:47
@tjarbo tjarbo mentioned this pull request Feb 6, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👓 need review This issue or pull request needs to be reviewed ⚡ improvement Verbesserung bestehender Funktionen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants