Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(git-clear): add --force and --help flags #828

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(git-clear): add --force and --help flags #828

wants to merge 3 commits into from

Conversation

kevinawoo
Copy link
Contributor

This PR adds the ability to do:

git-clear --force
git-clear -f
git-clear --help
git-clear -h

git-clear-soft --force
git-clear-soft -f
git-clear-soft --help
git-clear-soft -h

spacewander
spacewander requested changes Apr 2, 2020
View reviewed changes
etc/bash_completion.sh
}

_git_clear_soft(){
local s_opts=( '-h' '-f' )
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just let _git_clear and _git_clear_soft call the same helper function?

bin/git-clear

while [ "X$1" != "X" ]; do
case $1 in
-f|--force)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a consistent indent style.

bin/git-clear-soft

while [ "X$1" != "X" ]; do
case $1 in
-f|--force)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacewander spacewander spacewander requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinawoo @spacewander