Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a few fixes in a row #175

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

a few fixes in a row #175

wants to merge 5 commits into from

Conversation

besser82
Copy link

@besser82 besser82 commented Jun 3, 2013

  • fixed grep: invalid max count
    • manning-up.sh had an error making grep for title fail
  • add output of file being processed
    • some output about which file gets processed by ronn, makes debugging easier
  • add missing hashbang
    • there was the hashbang missing in bin/git-obliterate
  • remove /usr/bin/env from hashbang
    • hashbang should not call shell-interpreter using env
  • fix complains from checkbashism -px
    • some scripts used bashisms, but relied on /bin/sh
    • /bin/sh neccessarily not needs to be symlinked to /bin/bash

@hemanth
Copy link
Collaborator

hemanth commented Jul 9, 2014

@besser82 This needs a rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants