Replace subshell command with builtin operation to infer DESTINATION_DIR

tj · Oct 20, 2023 · 8eb77fc · 8eb77fc
1 parent b867455
commit 8eb77fc
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/bin/git-cp b/bin/git-cp
@@ -38,13 +38,15 @@ else
  exit 40
  fi
 
- DESTINATION_DIR="$(dirname "$DESTINATION_FILENAME")"
+ if [[ "$DESTINATION_FILENAME" == */ ]]; then
+ echo 1>&2 "$DESTINATION_FILENAME is not a file path."
+ exit 80
+ fi
+ DESTINATION_DIR="${DESTINATION_FILENAME%/*}"
  if [ ! -d "$DESTINATION_DIR" ]; then
- echo "Creating destination directory: $DESTINATION_DIR"
- mkdir -p "$DESTINATION_DIR"
- if [ $? -ne 0 ]; then
+ if ! mkdir -p "$DESTINATION_DIR"; then
  echo 1>&2 "Failed to create destination directory: $DESTINATION_DIR"
- exit 80
+ exit 160
  fi
  fi