Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chat] Chat infinite scroll을 위한 IntersectionObserver intersection time 기준 변경 #2867

Closed
wants to merge 4 commits into from

Conversation

dia-triple
Copy link
Contributor

@dia-triple dia-triple commented Aug 25, 2023

PR 설명

  • iOS 모바일 사파리에서 ChatPopup과 함께 사용되었을 때 init 시점에 infinite scroll이 트리거 되어 bottom으로 이동하는 스크롤과, top으로 이동하는 스크롤이 중첩되는 현상을 수정합니다.
    • iOS 모바일 사파리에서 Intersecting이 팝업 오픈 transform이 모두 완료된 이후 true로 변경되어(iOS 모바일 사파리에서는 Intersecting 상태가 transform에 영향을 받는 것으로 예상됨, 관련 이슈) init 시점에 bottom으로 이동하는 스크롤과, top으로 이동하는 스크롤이 중첩되어 스크롤이 부자연스러운 오류가 발생합니다.

변경 내역

체크리스트

스크린샷 & URL

@dia-triple
Copy link
Contributor Author

release-canary

@github-actions
Copy link

v13.2.5-pr-2867.0 has been published!

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (ebe0ec1) 27.53% compared to head (4170efc) 27.52%.

❗ Current head 4170efc differs from pull request most recent head 3754a46. Consider uploading reports for the commit 3754a46 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2867      +/-   ##
==========================================
- Coverage   27.53%   27.52%   -0.01%     
==========================================
  Files         688      688              
  Lines       37212    37218       +6     
  Branches     8982     8985       +3     
==========================================
  Hits        10245    10245              
- Misses      26955    26961       +6     
  Partials       12       12              
Files Changed Coverage Δ
packages/chat/src/chat/chat.tsx 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dia-triple
Copy link
Contributor Author

release-canary

@github-actions
Copy link

v13.2.5-pr-2867.1 has been published!

@dia-triple dia-triple changed the title test: chat IntersectionObserver intersection time 기준 변경 [Chat] Chat infinite scroll을 위한 IntersectionObserver intersection time 기준 변경 Aug 28, 2023
@dia-triple dia-triple force-pushed the test/chat-inspection branch from 4170efc to 3175943 Compare August 28, 2023 01:51
@dia-triple dia-triple force-pushed the test/chat-inspection branch from 3175943 to cd7cba9 Compare August 28, 2023 01:53
@dia-triple dia-triple closed this Aug 28, 2023
@dia-triple dia-triple deleted the test/chat-inspection branch August 28, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant