-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
turborepo 추가 #2011
turborepo 추가 #2011
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2011 +/- ##
=======================================
Coverage 31.77% 31.77%
=======================================
Files 545 545
Lines 10310 10310
Branches 3068 3068
=======================================
Hits 3276 3276
Misses 6765 6765
Partials 269 269
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
패키지 생성 시 필요한 package.json 양이 늘어났으니 스캐폴딩의 요구도 더 커졌네용. 그런데 CI에서 수행하는 build
스크립트 이후 산출물은 캐싱이 되고 있는 걸까용? actions/cache
는 node_modules만 보고 있을 것 같은데, 빌드 아티팩트를 캐싱해두면 partial build를 잘 활용할 수 있을거라고 생각했어요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build:ci 제거 건이 있으므로 조심스럽게 적용해봐야겠군요
e13b5aa
to
ae35520
Compare
2ed36eb
to
74e7c98
Compare
https://github.com/titicacadev/triple-frontend/runs/5655500375?check_suite_focus=true#step:6:632 빌드 캐시 적용되었습니다! |
와... 저세상의 빌드시간이네요 ㅋㅋㅋ |
b898615
to
4fe74e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚡
4fe74e5
to
405b522
Compare
release-canary |
v7.1.1-pr-2011.39 has been published! |
0372cdc
to
fec232f
Compare
이거 이제 머지해보려고 합니다. 다시 리뷰 한번 부탁드립니다. |
cf60ab5
to
41379cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오.. 기대됩니다
PR 설명
#1913
변경 내역
build:ci 를 제거합니다. 약 4개월전 next.js 빌드시에 발생하던 이상현상을 우회하기 위해 추가된 스크립트인데 이제는 해결되었다고 예상합니다. https://titicaca.slack.com/archives/CEEPB4TDY/p1636436871218400