-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
security upgrade: the core project j2html had an insecure dependency … #229
base: master
Are you sure you want to change the base?
Conversation
…(a very old apache velocity). also added an GETTING_STARTED.md document, so it is easier getting started with this project.
can I help you maintaining this open source project? Last update seems in 2022, so the development seems inactive. If possible I would like to become a maintainer of this project. |
@koaben I would be happy for more maintainers to join. I stopped maintaining this a long time ago and onboarded @sembler, but I don't think he would mind the company (?) |
I wouldn't mind at all. In fact life has steadily grown more busy for me and I'm severely limited in what I can contribute. Having another maintainer will give this project a better chance to survive. |
ok. ;-). Let's help this project ;-) and make it a fun project for everyone ;-). QUESTION: Should we still support Java8 (the build fails because of Javalin 6.1.3 does not build with Java8)? Because the current old Javalin 4.0.0 has some insecure dependencies and the newest Javalin 6.1.3 does not support Java8. POSSIBLE SOLUTION: Perhaps if we split the j2html-website sub-project into a separate git-repository, then this main project can still support Java8. But why support Java8? Better to focus on Java21+ than on Java8? |
…he outdated Java8
Good day @tipsy and @sembler, an update: I have updated the github workflow so the project now builds for Java21, Java17 and Java11 (and the failing Java8 is removed, no longer maintainable with the new dependencies). 2 Questions:
|
Let me configure the appropriate access this weekend. Ping me if I forget ! |
Ok. Thanks @tipsy (and @sembler)! A first clear goal is to publish a new release of j2html on https://mvnrepository.com/artifact/com.j2html/j2html (the next version will be without security issues in dependencies, so no troubles anymore with CVE-2020-13936). This will allow more people to use j2html ;-). Question: I have never done this before, can you sketch the main steps I should execute for this goal for j2html? It would really be appreciated ;-) |
Ping ;-) |
The security issue is in a test dependency, so not something that is included in the current release :)
I am still the only one who can release, as long as I keep the repo on my GitHub user I want it do stay like that.
I don't think this is necessarily the right approach, j2html doesn't actually have any dependencies as far as I can remember. The dependencies are all in the supporting modules or using the |
security upgrade: the core project j2html had an insecure dependency (a very old apache velocity).
also added an GETTING_STARTED.md document, so it is easier getting started with this project.