Update swap examples #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anlerkan
requested changes
Feb 20, 2024
| @@ -30,42 +30,33 @@ export async function fixedOutputSwap({ | |||
| * Swap.getQuote method, which will return the best quote (highest rate) | |||
| * after checking both v1 and v2 | |||
| */ | |||
| const fixedOutputSwapQuote = Swap.v2.getQuote( | |||
| SwapType.FixedOutput, | |||
| const fixedOutputSwapQuote = await Swap.v2.getQuote({ | |||
There was a problem hiding this comment.
These examples use the swap router by default. Can you please add an example that does not use the swap router for both fixedInputSwap and fixedOutputSwap.
gulcinuras
reviewed
Feb 23, 2024
There was a problem hiding this comment.
Hey @tatata96, some of the files seem unformatted. If you can format them all, would be great
added 2 commits
March 7, 2024 13:36
add condition for addInitialLiquidtiy add example without swap router to fixedOutputSwap format files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.