Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap route v2 - implement v2 changes #101

Merged
merged 15 commits into from
Jan 13, 2025
Merged

Swap route v2 - implement v2 changes #101

merged 15 commits into from
Jan 13, 2025

Conversation

gulcinuras
Copy link
Contributor

  • Get transaction recipes from the api and convert the values into correct types to generate swap router transactions
  • Create EXECUTOR_FALLBACK_ADDRESS in the account constants and use it in the governance and swap-router
  • Use joinByteArrays util function instead of concatUint8Arrays

@gulcinuras
feat(liquid-stake): Get transaction recipe from the api and convert t…
7dc54a7 
…he values into correct types to generate swap router txns
@gulcinuras gulcinuras self-assigned this Dec 19, 2024
@linear Linear
Copy link

linear bot commented Dec 19, 2024

TINY-1773

@gulcinuras
chore(package): Bump up the app version
98037c8
@gulcinuras
Add deprecation mark to swap v1_1
7cfc442
@gulcinuras
fix(swap-router): Implement types correctly, get swap route assets fr…
577473f 
…om api
@gulcinuras
fix(swap-router): Set transactions type correctly
1eacc9f
@gulcinuras
fix(swap-router): Return empty array if txns don't exist
300dd2d
@gulcinuras
fix(swap-router): Return output_amount
539f6a6
@gulcinuras
Convert amount into input_amount
4c2ba05
@gulcinuras
fix(swap-router): Update payload
5cf1b82
@gulcinuras
Remove unncecessary console.log
68483be
@gulcinuras
Bump up the app version
b076cc3
@gulcinuras
fix(swap-router): Get swap_fee from api response
8953290 
- Add extra checks for asset ids and amounts
@gulcinuras
fix(swap-router): Send slippage as a parameter and use the asset amou…
ecfc784 
…nt value directly from the recipe
@gulcinuras
make sure the asset amounts are in BigInt type
e3c1d31
@gulcinuras
fix(swap-router): Make sure amount is in bigint type as well
29795f6
@gulcinuras gulcinuras requested a review from etzellux January 13, 2025 15:20
etzellux
etzellux approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@etzellux etzellux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gulcinuras gulcinuras merged commit cfec8cf into main Jan 13, 2025
@gulcinuras gulcinuras deleted the feat/tiny-1773-swap-router-v2 branch January 13, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etzellux etzellux etzellux approved these changes

Assignees

@gulcinuras gulcinuras

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gulcinuras @etzellux