Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows: don't return in mainCRTStartup, exit via exit(0) instead #4612

Merged
merged 1 commit into from
Nov 19, 2024
Merged

windows: don't return in mainCRTStartup, exit via exit(0) instead #4612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/runtime/runtime_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,16 @@ func mainCRTStartup() int {
stackTop = getCurrentStackPointer()
runMain()

// For libc compatibility.
// Exit via exit(0) instead of returning. This matches
// mingw-w64-crt/crt/crtexe.c, which exits using exit(0) instead of
// returning the return value.
// Exiting this way (instead of returning) also fixes an issue where not all
// output would be sent to stdout before exit.
// See: https://github.com/tinygo-org/tinygo/pull/4589
libc_exit(0)

// Unreachable, since we've already exited. But we need to return something
// here to make this valid Go code.
return 0
}

Expand Down
Loading