Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/File: add stubs for os.File Deadlines #4465

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

leongross
Copy link
Contributor

@leongross leongross commented Sep 12, 2024

add os.SetDeadline, os.SetReadDeadline, os.SetWriteDeadline stubs for posix files.

add os.SetDeadline, os.SetReadDeadline, os.SetWriteDeadline stubs for
posix files.

Signed-off-by: leongross <[email protected]>
@leongross
Copy link
Contributor Author

Copy link
Member

@deadprogram deadprogram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit overall, but can we add a smoke test?

Signed-off-by: leongross <[email protected]>
@deadprogram
Copy link
Member

Thank you very much @leongross now squash/merging.

@deadprogram deadprogram merged commit 84048f2 into tinygo-org:dev Sep 17, 2024
17 checks passed
@leongross
Copy link
Contributor Author

Thank you very much @leongross now squash/merging.

Thanks for the fast review and merge @deadprogram !

@leongross leongross deleted the set-deadline branch September 17, 2024 16:29
leongross added a commit to leongross/tinygo that referenced this pull request Sep 23, 2024
os/File: add stubs for os.File Deadlines
* add os.SetDeadline, os.SetReadDeadline, os.SetWriteDeadline stubs for
posix files.
* deadline: add tests

Signed-off-by: leongross <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants