Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mips: better support big-endian MIPS #4430

Merged
merged 2 commits into from
Sep 5, 2024
Merged

mips: better support big-endian MIPS #4430

merged 2 commits into from
Sep 5, 2024

Commits on Aug 22, 2024

  1. interp: support big-endian targets

    The interp package was assuming that all targets were little-endian. But
    that's not true: we now have a big-endian target (GOARCH=mips).
    
    This fixes the interp package to use the appropriate byte order for a
    given target.
    aykevl committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    490a853 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. reflect: support big-endian systems

    The reflect package needs to know the endianness of the system in a few
    places. Before this patch, it assumed little-endian systems. But with
    GOARCH=mips we now have a big-endian system which also needs to be
    supported. So this patch fixes the reflect package to work on big-endian
    systems.
    
    Also, I've updated the tests for MIPS: instead of running the
    little-endian tests, I've changed it to run the big-endian tests
    instead. The two are very similar except for endianness so this should
    be fine. To be sure we won't accidentally break little-endian support,
    I've kept a single MIPS little-endian test (the CGo test, which doesn't
    yet work on big-endian systems anyway).
    aykevl committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    1aa837e View commit details
    Browse the repository at this point in the history