Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Fork and Exec libc hooks #4358

Merged
merged 1 commit into from
Jul 23, 2024
Merged

add Fork and Exec libc hooks #4358

merged 1 commit into from
Jul 23, 2024

Conversation

leongross
Copy link
Contributor

Add wrappers for fork and Exec so that #4323 can invoke these functionalities properly.

@leongross leongross marked this pull request as ready for review July 23, 2024 10:18
@deadprogram
Copy link
Member

Seems fine to me @aykevl @dgryski @dkegel-fastly any comments?

dkegel-fastly
dkegel-fastly approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@dkegel-fastly dkegel-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deadprogram
Copy link
Member

Thanks @leongross for the addition and to @dkegel-fastly for the review. Now merging.

@deadprogram deadprogram merged commit b318a94 into tinygo-org:dev Jul 23, 2024
17 checks passed
@leongross
Copy link
Contributor Author

Thanks for the fast response @deadprogram and the quick review @dkegel-fastly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkegel-fastly dkegel-fastly dkegel-fastly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leongross @deadprogram @dkegel-fastly