Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just in case you want this code, I implemented the new pass manager. Looks like soon this will be the only pass manager API available as they will be removing the old APIs.
This API looks like it's been available since LLVM 14 or earlier, so I think it should be safe.
I added a test.... it's mostly copy pasta from another test, but hey it's better than nothing, and it checks that the error handling code is correct.
Let me know if you're interested in these PRs. If you're not, I can just maintain my own fork. I understand you not wanting to maintain code that is not depended upon by tinygo. Though, in this case, I think you might want this code as it will be required eventually.
Feel free to close this PR and go a different direction, or make any edits you would like, I don't mind.