Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make functioning build with 'gulp dist' #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oddgoo
Copy link

@oddgoo oddgoo commented Oct 7, 2015

'gulp dist' was not building a functioning distribution. System.js wasn't found and there was no executable entry point to the rest of the app.

To fix this, I:

  • Changed the order of the htmlReplace js parameters, to put 'js/system.js' at the top.
  • Added a new htmlReplace block, to add an entry point to 'src/app.js' in index.html

Perhaps this is better solved by flagging the app.js file as a --script, instead of a --module, but I did not know how to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant