make protoc installation script respect proxy env #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
reviewed
Apr 13, 2023
packages/protoc/package-lock.json
Outdated
| @@ -1,5 +1,599 @@ | |||
| { | |||
| "name": "@protobuf-ts/protoc", | |||
| "version": "2.8.3", | |||
| "lockfileVersion": 1 | |||
| "lockfileVersion": 3, | |||
There was a problem hiding this comment.
I'm not sure this will work. CI runs with Node 14.5 (see here), and I don't know at the top of my head if it handles lock file version 3 correctly. Could you use nvm or fnm to switch to the old Node version, and re-create the lock file?
There was a problem hiding this comment.
I've regenerated the lock file using node 14.5, See my latest force push with the updated commit.
mikonse
force-pushed
the
proxy-aware-protoc-installation-fixed
branch
from
8c661cb
to
7d1a8ee
Compare
|
Any update on this? Is there anything I can help with to get this merged? |
|
any updates on this? +1 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #507
this is a correct version of #508 with a fixed package-lock.json