Add global type registry #371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you still working on this, and is there anything I can do to help? Would be very useful. |
|
Full disclosure: I haven't touched this PR since I opened it, but we've been using this implementation internally since then. Where I was unsure is with the typecast that I had to do after the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When messages are imported, add them to a global type registry as a side-effect. That allows users to omit
typeRegistrywhen interacting withAny.I'm adding this a draft right now, because this definitely requires changes to the docs, and probably another test case. I'm also not sure about the typecast I'm using in
jsonReadOptionsandjsonWriteOptions. I originally did this implementation as a patch to the compiled package, so there were no types.Closes #131