Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: show number of merge requests in project card. #95

Open
Feng-Yin opened this issue Sep 6, 2019 · 7 comments
Open

Feature: show number of merge requests in project card. #95

Feng-Yin opened this issue Sep 6, 2019 · 7 comments
Labels
enhancement New feature or request pr wanted

Comments

@Feng-Yin
Copy link

Feng-Yin commented Sep 6, 2019

Hi, awesome job on the dashboard! Pls consider adding merge request related info to the dashboard. We had the issue of promoting the actively review the merge request in a timely manner.

@timoschwarzer
Copy link
Owner

Hmm, gitlab-monitor's original intention is to display real-time pipeline information, which merge requests are not part of. So I don't think I'll implement that really specific feature.

@timoschwarzer
Copy link
Owner

I'm open to more opinions though.

@timoschwarzer timoschwarzer added enhancement New feature or request help wanted Extra attention is needed labels Sep 6, 2019
@Feng-Yin
Copy link
Author

Feng-Yin commented Sep 16, 2019

I got a patch for showing open merge request on project card top-right corner
showOpenMergeRequestCount.patch.txt

@devpie
Copy link

devpie commented Oct 18, 2019

I think showing this kind of information is a great thing. At my last employer we build our own Web-Application for additionally showing open MRs respectively open code reviews, but in an additional badge, which went from green, when no MRs where available to orange to red, when there were more than x and y MRs. This showed us to keep up with the stuff from others and review their code, which really enhanced i.e. our lead time.

@timoschwarzer
Copy link
Owner

Alright, as there seems to be demand, I'd be fine with little badges at the top right corner of each project card. Users can enable the badges with a config in projectConfig.

e.g.

projectConfig:
  '*': # or 'johndoe/someproject'
    badges:
      mergeRequests: true

@Morl99
Copy link

Morl99 commented Dec 2, 2020

I think that would be helpful. Do you still have plans to implement this? Or does 'help-wanted' mean you would be open to PRs about this?

@timoschwarzer
Copy link
Owner

@Morl99 probably not going to implement this myself, but I'm open for PRs :)

@timoschwarzer timoschwarzer added pr wanted and removed help wanted Extra attention is needed labels Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pr wanted
Projects
None yet
Development

No branches or pull requests

4 participants