Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't error on empty typeinf flamegraph; print a warning instead #332

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

NHDaly
Copy link
Collaborator

@NHDaly NHDaly commented Jan 5, 2023

@NHDaly NHDaly requested a review from timholy January 5, 2023 23:28
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 83.56% // Head: 83.56% // No change to project coverage 👍

Coverage data is based on head (0ad1e5f) compared to base (4e00e22).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   83.56%   83.56%           
=======================================
  Files          17       17           
  Lines        2178     2178           
=======================================
  Hits         1820     1820           
  Misses        358      358           
Impacted Files Coverage Δ
src/parcel_snoopi_deep.jl 90.01% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@NHDaly NHDaly merged commit 4dba505 into master Jan 6, 2023
@NHDaly NHDaly deleted the nhd-empty-profile-flamegraph branch January 6, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants