Fix "juliadir" test #867
Merged
Fix "juliadir" test #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
force-pushed
the
kf/juliadirtest
branch
3 times, most recently
from
ce16a23 to
1c80fb8
Compare
The test was ineffective because it was relying on binding replacement, which is undefined behavior on all versions of Julia (ironically it will not be in 1.12, but that change is not done yet). As a result, the redefinition of `juliadir` was not taking effect and the test was simply running with the old juliadir. Change `juliadir` to a (typed) global and update the test to make sure it's actually working.
Keno
force-pushed
the
kf/juliadirtest
branch
from
1c80fb8 to
73e520e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was ineffective because it was relying on binding replacement, which is undefined behavior on all versions of Julia (ironically it will not be in 1.12, but that change is not done yet). As a result, the redefinition of
juliadirwas not taking effect and the test was simply running with the old juliadir. Changejuliadirto a (typed) global and update the test to make sure it's actually working.