Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture log message instead of telling users to ignore it #844

Merged
merged 1 commit into from
Sep 22, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -948,8 +948,8 @@ const issue639report = []
""")
sleep(mtimedelay)
write(joinpath(dn, "file.jl"), "struct Ord2 end")
@info "The following error message is expected for this broken test"
yry()
# TODO: remove also the log messages check when this test is fixed
@test_logs (:error, r"Failed to revise") (:warn, r"The running code does not match the saved version") yry()
@test_broken Order2.f(Order2.Ord2()) == 1
# Resolve it with retry
Revise.retry()
Expand Down
Loading