Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do a little bit of work to try confirm that the git repo found is actually a julia repo before running Core.Compiler test #836

Merged
merged 4 commits into from
Aug 14, 2024
Merged

do a little bit of work to try confirm that the git repo found is actually a julia repo before running Core.Compiler test #836

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
55a5450
do a little bit of work to try confirm that the git repo found is act…
KristofferC Aug 1, 2024
d6a7ea8
do not run on buildkite
KristofferC Aug 14, 2024
f1241af
Update runtests.jl
KristofferC Aug 14, 2024
3e5ddf0
dsadasdsa
KristofferC Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2878,19 +2878,21 @@ const issue639report = []

Revise.get_tracked_id(Core) # just test that this doesn't error

# Determine whether a git repo is available. Travis & Appveyor do not have this.
repo, path = Revise.git_repo(Revise.juliadir)
if repo != nothing
# Tracking Core.Compiler
Revise.track(Core.Compiler)
id = Base.PkgId(Core.Compiler)
pkgdata = Revise.pkgdatas[id]
@test any(k->endswith(k, "optimize.jl"), Revise.srcfiles(pkgdata))
m = first(methods(Core.Compiler.typeinf_code))
@test definition(m) isa Expr
else
@test_throws Revise.GitRepoException Revise.track(Core.Compiler)
@warn "skipping Core.Compiler tests due to lack of git repo"
if !haskey(ENV, "BUILDKITE") # disable on buildkite, see discussion in https://github.com/JuliaCI/julia-buildkite/pull/372#issuecomment-2262840304
# Determine whether a git repo is available. Travis & Appveyor do not have this.
repo, path = Revise.git_repo(Revise.juliadir)
if repo != nothing && isfile(joinpath(path, "VERSION")) && isdir(joinpath(path, "base"))
# Tracking Core.Compiler
Revise.track(Core.Compiler)
id = Base.PkgId(Core.Compiler)
pkgdata = Revise.pkgdatas[id]
@test any(k->endswith(k, "optimize.jl"), Revise.srcfiles(pkgdata))
m = first(methods(Core.Compiler.typeinf_code))
@test definition(m) isa Expr
else
@test_throws Revise.GitRepoException Revise.track(Core.Compiler)
@warn "skipping Core.Compiler tests due to lack of git repo"
end
end
end

Expand Down
Loading