-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More 1.12 compat #827
More 1.12 compat #827
Conversation
With this and the LCU fixes, Revise should pass tests again on 1.12.
Updated to bump LCU and cherry-pick the additional fixes from #829 |
Interesting that the linux testers don't know about LCU 3.0.1. |
Probably just hadn't propagated yet. Rerunning. |
@timholy The last issue here is that |
That's mostly a separate change though. I would propose merging this first and then addressing that last issue. |
Yes, that needs to happen. I have been doing that for newer tests, but I haven't migrated old tests. Doesn't need to stand in the way of this PR. |
With this and the LCU fixes, Revise should pass tests again on 1.12.