Correct pc for empty function definition #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting `pc=nothing` is premature at this stage. Together with JuliaDebug/LoweredCodeUtils.jl#91, this fixes #758.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
pc=nothingis premature at this stage.Together with JuliaDebug/LoweredCodeUtils.jl#91, this fixes #758.
This will fail the new test because I haven't tagged a new release of LoweredCodeUtils. However, that's a bit unsafe to release without this change---it will trigger this bug more often than it used to. So I'll let this test fail, merge & make a new Revise release, and then release LoweredCodeUtils.