minor updates on old code

[aviatesk]

Since the minimum version compat for Revise is now 1.6, we can expect GotoIfNot to be defined within Core always.

[rben01]

This seems related to this error I just started getting in VSCode:

[ Info: Precompiling Revise [295af30f-e4ad-537b-8983-00126c2a3abe]
ERROR: LoadError: UndefVarError: `is_GotoIfNot` not defined
Stacktrace:
 [1] include
   @ ./Base.jl:457 [inlined]
 [2] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::String)
   @ Base ./loading.jl:2049
 [3] top-level scope
   @ stdin:3
in expression starting at /Users/rben01/.julia/packages/LoweredCodeUtils/30gbF/src/LoweredCodeUtils.jl:1
in expression starting at stdin:3
ERROR: LoadError: Failed to precompile LoweredCodeUtils [6f1432cf-f94c-5a45-995e-cdbf5db27b0b] to "/Users/rben01/.julia/compiled/v1.9/LoweredCodeUtils/jl_Ubzh1I".
Stacktrace:
  [1] error(s::String)
    @ Base ./error.jl:35
  [2] compilecache(pkg::Base.PkgId, path::String, internal_stderr::IO, internal_stdout::IO, keep_loaded_modules::Bool)
    @ Base ./loading.jl:2294
  [3] compilecache
    @ ./loading.jl:2167 [inlined]
  [4] _require(pkg::Base.PkgId, env::String)
    @ Base ./loading.jl:1805
  [5] _require_prelocked(uuidkey::Base.PkgId, env::String)
    @ Base ./loading.jl:1660
  [6] macro expansion
    @ ./loading.jl:1648 [inlined]
  [7] macro expansion
    @ ./lock.jl:267 [inlined]
  [8] require(into::Module, mod::Symbol)
    @ Base ./loading.jl:1611
  [9] include
    @ ./Base.jl:457 [inlined]
 [10] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::Nothing)
    @ Base ./loading.jl:2049
 [11] top-level scope
    @ stdin:3
in expression starting at /Users/rben01/.julia/packages/Revise/xRltd/src/Revise.jl:1
in expression starting at stdin:3
ERROR: Failed to precompile Revise [295af30f-e4ad-537b-8983-00126c2a3abe] to "/Users/rben01/.julia/compiled/v1.9/Revise/jl_bfh48Z".
Stacktrace:
  [1] error(s::String)
    @ Base ./error.jl:35
  [2] compilecache(pkg::Base.PkgId, path::String, internal_stderr::IO, internal_stdout::IO, keep_loaded_modules::Bool)
    @ Base ./loading.jl:2294
  [3] compilecache
    @ ./loading.jl:2167 [inlined]
  [4] _require(pkg::Base.PkgId, env::String)
    @ Base ./loading.jl:1805
  [5] _require_prelocked(uuidkey::Base.PkgId, env::String)
    @ Base ./loading.jl:1660
  [6] macro expansion
    @ ./loading.jl:1648 [inlined]
  [7] macro expansion
    @ ./lock.jl:267 [inlined]
  [8] require(into::Module, mod::Symbol)
    @ Base ./loading.jl:1611
  [9] eval
    @ ./boot.jl:370 [inlined]
 [10] eval
    @ ./Base.jl:68 [inlined]
 [11] repleval(m::Module, code::Expr, #unused#::String)
    @ VSCodeServer ~/.vscode/extensions/julialang.language-julia-1.60.2/scripts/packages/VSCodeServer/src/repl.jl:229
 [12] (::VSCodeServer.var"#110#112"{Module, Expr, LineEditREPL, REPL.LineEdit.Prompt})()
    @ VSCodeServer ~/.vscode/extensions/julialang.language-julia-1.60.2/scripts/packages/VSCodeServer/src/repl.jl:192
 [13] with_logstate(f::Function, logstate::Any)
    @ Base.CoreLogging ./logging.jl:514
 [14] with_logger
    @ ./logging.jl:626 [inlined]
 [15] (::VSCodeServer.var"#109#111"{Module, Expr, LineEditREPL, REPL.LineEdit.Prompt})()
    @ VSCodeServer ~/.vscode/extensions/julialang.language-julia-1.60.2/scripts/packages/VSCodeServer/src/repl.jl:193
 [16] #invokelatest#2
    @ ./essentials.jl:819 [inlined]
 [17] invokelatest(::Any)
    @ Base ./essentials.jl:816
 [18] macro expansion
    @ ~/.vscode/extensions/julialang.language-julia-1.60.2/scripts/packages/VSCodeServer/src/eval.jl:34 [inlined]
 [19] (::VSCodeServer.var"#62#63")()
    @ VSCodeServer ./task.jl:514

[aviatesk]

You need to update the dependencies too.

[rben01]

@aviatesk I ran ]update; no change.

[aviatesk]

What happens if you do pkg> add [email protected]?

[fingolfin]

I also get that error; however with Revise 3.4.0, which I pinned as all newer versions seem to suffer from issue #734

[fingolfin]

Doing pkg> add [email protected] changes nothing for me -- this is with Julia 1.9.3 and Revise 3.4.0.

So clearly this is not an error just with Revise, but rather something else changed?

Aha, doing add [email protected] to downgrade from 0.9.27 did the trick for me. So maybe 0.9.27 can be yanked and replaced by 0.10.0?