Skip to content

Commit

Permalink
Skip a problematic test on 1.6 (#848)
Browse files Browse the repository at this point in the history 
On Windows, Julia 1.6, the signatures test fails with

```
Base signatures: Error During Test at D:\a\Revise.jl\Revise.jl\test\runtests.jl:3851
  Got exception outside of a @test
  LoadError: invalid redefinition of constant RandomDevice
  Stacktrace:
   [1] do_assignment!(frame::Frame, lhs::Any, rhs::Any)
     @ JuliaInterpreter C:\Users\runneradmin\.julia\packages\JuliaInterpreter\cxlKp\src\interpret.jl:352
  in expression starting at D:\a\Revise.jl\Revise.jl\test\sigtest.jl:106
```

Since this only happens on a soon-to-be-unsupported Julia release, let's just ignore the test.
  • Loading branch information
@timholy
timholy authored Sep 25, 2024
1 parent 1b2dc22 commit 33ee1c8
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions test/sigtest.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ end
basefiles = Set{String}()
@time for (i, (mod, file)) in enumerate(Base._included_files)
(endswith(file, "sysimg.jl") || endswith(file, "Base.jl")) && continue
Base.VERSION < v"1.7" && Sys.iswindows() && endswith(file, "RNGs.jl") && continue # invalid redefinition of constant RandomDevice
file = Revise.fixpath(file)
push!(basefiles, reljpath(file))
mexs = Revise.parse_source(file, mod)
Expand Down

2 comments on commit 33ee1c8

@timholy
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/115940

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v3.6.0 -m "<description of version>" 33ee1c87a6b2c95a58cf9b14ba5ad25195cda3a9
git push origin v3.6.0

Please sign in to comment.