Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force DateStyle and DateOrder in materialization #7319

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

fabriziomello
Copy link
Contributor

@fabriziomello fabriziomello commented Oct 4, 2024

Disable-check: force-changelog-file
Disable-check: commit-count

@fabriziomello fabriziomello self-assigned this Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.13%. Comparing base (59f50f2) to head (bc5bffd).
Report is 379 commits behind head on main.

Files with missing lines Patch % Lines
tsl/src/continuous_aggs/materialize.c 42.85% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7319      +/-   ##
==========================================
+ Coverage   80.06%   82.13%   +2.06%     
==========================================
  Files         190      217      +27     
  Lines       37181    38917    +1736     
  Branches     9450    10036     +586     
==========================================
+ Hits        29770    31965    +2195     
+ Misses       2997     2963      -34     
+ Partials     4414     3989     -425     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Also bump alpine images to 3.19 and 3.20 since last minor PG releases
are not available on 3.18 anymore.

Alpine 3.20 was released with tzdata-2024b and it is kinda of broken
using timezone PST8PDT so forced downgrade to tzdata-2024a.

postgres/postgres@b8ea0f67
@fabriziomello fabriziomello force-pushed the cagg_force_datestyle_and_order_in_materialize branch from bc5bffd to 904176c Compare October 5, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant