Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Postgres logs noise on regression tests #7043

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fabriziomello
Copy link
Contributor

@fabriziomello fabriziomello commented Jun 18, 2024

For each regression database created we execute the test/sql/utils/testsupport.sql to setup some test stuff before actually run the tests. Once we config Postgres to emit log for all executed statements we create a log of noise on logs about this setup SQL script.

Change it to run the setup SQL script on the template1 database so all new created databases will contain all the necessary objects for run the tests.

Disable-check: force-changelog-file

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.07%. Comparing base (59f50f2) to head (2b385d5).
Report is 379 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7043      +/-   ##
==========================================
+ Coverage   80.06%   81.07%   +1.01%     
==========================================
  Files         190      217      +27     
  Lines       37181    38729    +1548     
  Branches     9450     9955     +505     
==========================================
+ Hits        29770    31401    +1631     
- Misses       2997     3302     +305     
+ Partials     4414     4026     -388     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabriziomello fabriziomello marked this pull request as draft June 18, 2024 23:33
@fabriziomello fabriziomello force-pushed the reduce_postgres_logs_noise_on_regression_tests branch 4 times, most recently from 1ae9d0f to c711dea Compare June 25, 2024 22:36
@fabriziomello fabriziomello marked this pull request as ready for review June 25, 2024 22:37
@fabriziomello fabriziomello force-pushed the reduce_postgres_logs_noise_on_regression_tests branch from c711dea to 56f882e Compare July 30, 2024 21:42
@fabriziomello fabriziomello force-pushed the reduce_postgres_logs_noise_on_regression_tests branch from 56f882e to 4cae7e5 Compare August 2, 2024 23:24
@fabriziomello fabriziomello force-pushed the reduce_postgres_logs_noise_on_regression_tests branch from 4cae7e5 to a601348 Compare August 14, 2024 22:48
@fabriziomello fabriziomello force-pushed the reduce_postgres_logs_noise_on_regression_tests branch from a601348 to 6c55fcd Compare August 29, 2024 12:56
For each regression database created we execute the
test/sql/utils/testsupport.sql to setup some test stuff before actually
run the tests. Once we config Postgres to emit log for all executed
statements we create a log of noise on logs about this setup SQL script.

Change it to run the setup SQL script on the `template1` database so all
new created databases will contain all the necessary objects for run the
tests.
@fabriziomello fabriziomello force-pushed the reduce_postgres_logs_noise_on_regression_tests branch from 6c55fcd to 2b385d5 Compare October 4, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants