Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(charm): simplify relation tests with new add_relation #17

Closed
wants to merge 2 commits into from

Conversation

jnsgruk
Copy link
Collaborator

@jnsgruk jnsgruk commented Aug 31, 2023

A new version of the ops library released yesterday which introduces a nice simplification in the test harness, meaning you can now add a relation, prime it with a unit, and specify app/unit data all within the same call.

This PR is just a simple refactoring to make the tests a little easier to read.

@jnsgruk jnsgruk requested a review from tim-hm August 31, 2023 07:51
@tim-hm tim-hm requested review from matthew-hagemann and removed request for tim-hm August 31, 2023 07:56
@matthew-hagemann matthew-hagemann deleted the simplify-charm-tests branch August 31, 2023 09:53
@matthew-hagemann
Copy link
Collaborator

matthew-hagemann commented Aug 31, 2023

Thank you! Merged with a rebase and push.
cc51eb6
b577df7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants