Pass GITHUB_SHA as build arg

tim-hat-die-hand-an-der-maus · Jun 8, 2022 · 7dd1fa3 · 7dd1fa3
1 parent ac44b15
commit 7dd1fa3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/build_publish.yml b/.github/workflows/build_publish.yml
@@ -29,7 +29,7 @@ jobs:
           username: ${{ github.repository_owner }}
           password: ${{ secrets.GITHUB_TOKEN }}
       - name: Build the tagged Docker image
-        run: docker build -e GITHUB_SHA=$GITHUB_SHA -t ghcr.io/tim-hat-die-hand-an-der-maus/preliminary-frontend:${GITHUB_SHA} .
+        run: docker build --build-arg GITHUBSHA=${GITHUB_SHA} -t ghcr.io/tim-hat-die-hand-an-der-maus/preliminary-frontend:${GITHUB_SHA} .
       - name: Push the tagged Docker image
         run: docker push ghcr.io/tim-hat-die-hand-an-der-maus/preliminary-frontend:${GITHUB_SHA}
 

diff --git a/Dockerfile b/Dockerfile
@@ -1,5 +1,7 @@
 FROM node:17-alpine3.15 as builder
 
+ARG GITHUBSHA
+
 WORKDIR /usr/src/app
 
 COPY babel.config.js .
@@ -8,7 +10,7 @@ COPY yarn.lock .
 COPY src/ src/
 COPY public/ public/
 
-RUN sed -i -e "s#__commit_sha__#$(echo ${GITHUB_SHA})#g" src/App.vue
+RUN sed -i -e "s#__commit_sha__#$GITHUBSHA#g" src/App.vue
 
 RUN yarn install
 RUN yarn build