Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashboard): update TiDB Dashboard to v8.5.0-bce95733 [master] #8764

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Nov 4, 2024

What problem does this PR solve?

Issue Number: ref #4257 #8767

Update TiDB Dashboard to v8.5.0-bce95733.

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Nov 4, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 4, 2024

Hi @baurine. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.63%. Comparing base (5d32653) to head (00e744c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8764      +/-   ##
==========================================
+ Coverage   75.58%   75.63%   +0.05%     
==========================================
  Files         461      461              
  Lines       72275    72275              
==========================================
+ Hits        54628    54666      +38     
+ Misses      14148    14120      -28     
+ Partials     3499     3489      -10     
Flag Coverage Δ
unittests 75.63% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@baurine
Copy link
Contributor Author

baurine commented Nov 4, 2024

oh, it seems pd release-8.5 branch has created, so we need to cherry-pick this PR to release-8.5 after this PR is merged.

@nolouch
Copy link
Contributor

nolouch commented Nov 4, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Nov 4, 2024
@nolouch nolouch added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 4, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 4, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-04 08:00:17.214440749 +0000 UTC m=+855130.053596290: ☑️ agreed by nolouch.
  • 2024-11-05 07:26:33.895024437 +0000 UTC m=+939506.734179983: ☑️ agreed by rleungx.

@rleungx
Copy link
Member

rleungx commented Nov 5, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit cfd8f34 into tikv:master Nov 5, 2024
26 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #8772.

@baurine baurine deleted the update-tidb-dashboard/master-v8.5.0-bce95733-1730702784 branch November 6, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants