Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy to docker hub #2

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Deploy to docker hub #2

wants to merge 1 commit into from

Conversation

Gnuk
Copy link
Member

@Gnuk Gnuk commented May 9, 2020

Closes #1

@pascalgrimaud
Copy link
Member

From my point of view, I'd prefer to have an automated build, rather than pushing a Docker image:

  • let Docker Hub clone the projet
  • Docker Hub will use the Dockerfile, build the image and publish it

The project would have only a Dockerfile, nothing else.
Then, you need some configuration at Docker Hub

Having a automated build is more trusted than a Docker image which has been pushed.

@Gnuk
Copy link
Member Author

Gnuk commented May 9, 2020

I don't understand your point because to make the image I build the sources from CI to obtain dist folder and add the result to the docker image. So your strategy is completely different because I should build the dist from the image and it's not the way I choose.

Or I don't understand what you want to do at goal.

@Gnuk Gnuk marked this pull request as draft May 11, 2020 07:17
@Gnuk
Copy link
Member Author

Gnuk commented May 11, 2020

I will apply some changes in order to use Docker directly instead of using a plugin

@pascalgrimaud
Copy link
Member

@Gnuk : do you need help to achieve this ?

@Gnuk
Copy link
Member Author

Gnuk commented Apr 2, 2021

If you want @pascalgrimaud don't hesitate to be the owner of this issue ;)

@pascalgrimaud
Copy link
Member

@Gnuk : as you are the lead of Tikui, how should we achieve this ?

  • using the CI pipeline, for pushing a new version to Docker Hub, for each merge (like this PR)
  • letting Docker Hub to trigger a build (using hooks) for each merge. With this solution, you'll have the "automated" build (which is better IMO)

tikui_docker_automated

@Gnuk
Copy link
Member Author

Gnuk commented Apr 6, 2021

WIth the second solution, are we able to wait it's done (or failing) during the pipeline ?

@pascalgrimaud
Copy link
Member

I think it's possible, but you'll need to activate the build in Docker Hub for all incoming pull requests
You'll have something like this:

docker_hub_tikui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy to docker Hub
3 participants