-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vulnxscan: Add cve-bin-tool scanner #75
base: main
Are you sure you want to change the base?
Conversation
e342ccd
to
f30739c
Compare
f30739c
to
bc4ffb5
Compare
We decided to not merge this for now. The main problem is that cve-bin-tool reports way too many false positives. As an example, in a recent test run on a Ghaf target, cve-bin-tool reported the following vulnerabilities that were not reported by any other scanners:
We end-up with the following list of vulns:
Quick manual triage:
Clearly, there's something wrong with the way cve-bin-tool matches vulnerable components (versions). |
Adds cve-bin-tool scanner to vulnxscan Signed-off-by: Henri Rosten <[email protected]>
bc4ffb5
to
7eee82c
Compare
Adds cve-bin-tool scanner to vulnxscan.
Why do we use cve-bin-tool fork instead of the upstream or the version in nixpkgs?
The main reason is, both the upstream and the nixpkgs versions require an older version of python packaging. This project (vulnxscan) also requires packaging, but it needs a newer version. This results a conflict in python dependencies. The cve-bin-tool fork we are using in this PR attempts to resolve the upstream cve-bin-tool python dependencies issues so that newer version of packaging can be used in cve-bin-tool. As soon as the issue is properly resoved upstream and in nixpkgs, we should change vulnxscan to also start using the cve-bin-tool version from nixpkgs.