Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the terminal enable list view for the Prompts combo box #328

Open
wants to merge 5 commits into
base: tm/upgrade-laravel-zero
Choose a base branch
from

Conversation

gcavanunez
Copy link
Contributor

@gcavanunez gcavanunez commented Oct 27, 2023

Highlights

  • Currently just swaps the enable command for a terminal combo box
  • Doesn't use the dev-support-older-php version of prompts

Notes

Initially aimed at trying to test the output from prompts, but seems like Prompts aims at ensuring regular ways of testings commands to be how we try to assert on them. (ref)

Screens

image
image

Issues/Odd behavior

Doesn't gracefully fallback, thus breaking tests

image
from this test it_can_enable_a_service_from_menu

@gcavanunez gcavanunez changed the title feat: prompts working state Change the terminal enable list view for the Prompts combo box Nov 9, 2023
@gcavanunez gcavanunez changed the title Change the terminal enable list view for the Prompts combo box (WIP) Change the terminal enable list view for the Prompts combo box Nov 9, 2023
@gcavanunez
Copy link
Contributor Author

After upgrading to "laravel/prompts": "^0.1.13" the error with the console being prompted during tests go away

This upgrade does require "laravel-zero/framework": "^10.1.1"

@gcavanunez gcavanunez changed the base branch from main to tm/upgrade-laravel-zero May 3, 2024 17:46
@mattstauffer
Copy link
Member

@gcavanunez I'm super interested in getting this merged. The install box has gotten out of hand! Do you need any help to get this moved forward?

@gcavanunez
Copy link
Contributor Author

@mattstauffer 100%!! Since this guy depends on bumping up to the latest version of laravel-zero, taking a look at this PR could trickle this one out

@gcavanunez gcavanunez changed the title (WIP) Change the terminal enable list view for the Prompts combo box Change the terminal enable list view for the Prompts combo box Aug 15, 2024
@gcavanunez gcavanunez marked this pull request as ready for review August 15, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants