initial build #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! True, didn't really think about it but it should be Maxnet.jl. What stops me from just changing that right now? No one is using this thing so how could that break things? |
|
I guess it might not create a problem - not sure. It's a problem if someone have copies on their disk already. you can try? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all the contents of my original repo to yours. You could merge and remove, or let me know if you only want parts.
One big issue I notice is that your module name is written in non-caps, which is then also true for your maxnet.jl file. So you will be settled for the lifetime of this repo with an unstandard spelling scheme for the module file. Changing the capitalization will have effect on linux but not on mac or windows, so that can break the repo.
I'm happy to take you through what some of this means, but I wrote this code > 2 years ago...