Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats use default_aes prior to computation #6099

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #3860.

Briefly, it makes a Stat$use_defaults() method that evaluates Stat$default_aes prior to Stat$setup_data().
This is convenient for filling in optional aesthetics, like weight.

@teunbrand
Copy link
Collaborator Author

Also came across this:

default_aes = aes(colour = "#3366FF", size = 0.5),

Where it seems weird to me that the stat declares aesthetics for the geom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default_aes not used in compute_*() methods
1 participant