add comments to date translation to clarify non-SQL origins (months(), days() on Postgres + Snowflake) #1491
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found myself confused while trying to trace back date translations in
dbplyr
to their non-SQL origins, specificallybase
vs.lubridate
functions:months()
tolubridate
, when the translations actually correspond tobase::months()
days()
tobase
R (actually corresponds tolubridate::days()
I've proposed minor comments to hopefully prevent this confusion for future folks referencing these backend-specific translations for
days()
andmonths()
(only available for Postgres and Snowflake - the latter was mirrored from the former).cc: @fh-afrachioni