-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batch effects and PCs blog posts #40
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @paupaiz, the blog posts look great! The only problem is that I am unable to get BlogDown to render them. I have had a little look and I think there are a few reasons for this:
- The PCs_SingleCell post requires the manual download of data. Instead, this data can be placed within the post's directory and included in the pull request.
- The BatchEffects post requires the
MergedNML
object created in the PCs_SingleCell post. Instead this should be recreated within the BatchEffects directory so that each post can work independently. - The two new post directories should be placed in the tidyomicsBlog/blog/content/post directory.
Hopefully the blog posts will be good to go once these changes are made. To check, you can run the commands blogdown::build_site(build_rmd = 'newfile')
then blogdown::serve_site()
to render the site locally with your changes. You may need to set the working directory to tidyomicsBlog/blog for BlogDown to find the blog files.
Let me know if you have any questions or if I have misunderstood anything. Thank you for your work.
@william-hutchison Thank you! I will implement your feedback next week after finals 😅 |
@william-hutchison happy holidays! could you please enable LFS in the repo (setting > options > Git LFS). I get this error: |
Hello All, weshould be parsimonious with rds object size and try to make them less than the standard limit for github. this because LFS is free for a limited space. we should try to make the object as light as possible, use xz compression, and if still too big, think about deleting some info still keeping the boggle interesting and information rich. well done both, let's try to solve this issue soon, and we will have the January post already! |
Hi team, sorry for the delay. Handling/compressing data this large was new territory for me. I compressed the files for the PCA tutorial as you suggested. for the batch effects, the data is publically available on Latch (similar to AWS), anyone can download it. Thank you! |
Hi @paupaiz, thanks for the update! I have a few more requests and then the blog posts should be good to go:
Because we hope to automatically render the blog page every time someone adds a new blog post, everything each Rmd file needs to run will need to already be available without manual intervention. To check if the blog is able to render successfully, you can set your working directory to tidyomicsBlog/blog then run Let me know if you have any questions and thanks again for your work! |
@william-hutchison, it would be good to add all these in the guidelines, so a new person that contributes knows pretty much what to do and not to do. |
@stemangiola good point. I have updated the blog contribution guide in #45. |
Hi @paupaiz, do you have any updates on your progress? The posts you wrote look great and we would love for them to be visible to others. Let me know if I can provide any assistance. Thanks again |
@william-hutchison submitting revision today :) thanks for following up! |
Hi @william-hutchison @stemangiola, I've implemented your feedback. Had to change the datasets so they are small now and in the correct paths. Thank you for your patience! |
Amazing, thank you @paupaiz! The posts are now rendering correctly and look great. If I could request one final change, would you be able to update the code with a few examples from our tidy ecosystem where possible? A few possible changes could be:
You can find examples of this here: https://github.com/stemangiola/tidyseurat. I have also made a few minor changes:
Thanks again and let me know if I can help with anything. |
Amazing! Can someone attach here the HTML of the vignette so I can give feedback? Thanks! |
Sure, they are a little bit hard to read in this format without any styling, but hopefully this is enough for you to provide feedback. |
looking forward to your feedback!